feat(MWPW-142267): Merch What's Included and Merch Mnemonic List (TwP) #4
Conversation
There was a problem hiding this comment.
Overal I like your approach with [slot="merch-whats-included"]
- There are some visual issues on mobile.
-
expecting a fragment with a specific name feels a bit limiting to me. Couldn't we use a
#merch-whats-includedhash or something similar? -
How to we close and go back to TWP without closing the modal?
| </merch-mnemonic-list> | ||
| <merch-mnemonic-list> | ||
| <div slot="icon"> | ||
| <merch-icon size="s" src="https://www.adobe.com/content/dam/shared/images/product-icons/svg/premiere.svg" alt="Premiere Pro"></merch-icon> |
There was a problem hiding this comment.
why do we need the div? can we add slot="icon" directly on merch-icon?
@yesil Please find my answers below.
|
|
@Axelcureno to make the PSI check green you can just provide a fake link, with your branch, you can check the example green pr here: |
|
URL for testing: |
|
web-components/build.mjs
Outdated
| entryPoints: ['./src/merch-twp-d2p.js'], | ||
| bundle: true, | ||
| banner, | ||
| outfile: './lib/merch-twp-d2p.js', |
There was a problem hiding this comment.
merch-twp-d2p is already being build below.
also ./lib has changed to ./libs
web-components/build.mjs
Outdated
| build({ | ||
| entryPoints: ['./src/merch-whats-included.js'], | ||
| bundle: true, | ||
| banner, | ||
| outfile: './lib/merch-whats-included.js', | ||
| format: 'esm', | ||
| plugins: [rewriteImports()], | ||
| external: ['lit'], | ||
| }), | ||
| build({ | ||
| entryPoints: ['./src/merch-mnemonic-list.js'], | ||
| bundle: true, | ||
| banner, | ||
| outfile: './lib/merch-mnemonic-list.js', | ||
| format: 'esm', | ||
| plugins: [rewriteImports()], | ||
| external: ['lit'], |
There was a problem hiding this comment.
I think these build entries are not needed.
…into rosahu/MWPW-147172 * 'rosahu/MWPW-147172' of https://github.com/adobecom/mas: feat(MWPW-142267): Merch What's Included and Merch Mnemonic List (TwP) (#4) MWPW-153962: update /lib to /libs (#30) MWPW-153658 audit script (#25) MWPW-153962: support maslibs approach (#28)
Introduces Merch What's Included and Merch Mnemonic List web components for TwP What's included screen.
Resolves: MWPW-142267
Test link: https://mwpw-142267--milo--adobecom.hlx.page/drafts/axel/block-samples/twp/illustrator#twpmodal
Migrated from https://git.corp.adobe.com/wcms/tacocat.js/pull/572
How it works in Milo
In merch-twp block
Given a merch-twp block, a third separator --- is expected and then below a link to the what's included screen modal content.
In merch-card block
A link with name "merch-whats-included" is expected (link text is authorable)
This PR also introduces 2 new web components, which are:
merch-whats-included
Contains link of whats-included modal content (works as an inline fragment) and lets the author configure number of rows in mobile to display before "+ See more".
merch-mnemonic-list
Contains content of what's included screen.
Assumptions
What's included is an experience only applicable to a CC All Apps merch card.
Supports unlimited number of columns
Supports configurable number of rows before displaying "+ See more" in mobile.
Preview URLs:
URL for testing: